Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to change capture rates and remove overwriting parameters in initialCap #1832

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

fschreyer
Copy link
Contributor

Purpose of this PR

Add switch to change capture rates of technologies with carbon capture. Also stop overwriting pm_emifac in initialCap to actually apply these changes in policy runs.

@robertpietzcker : To finally fully avoid these issues in the future, I'd like to stop overwriting more of the parameters. Some of them do not need initialCap results. What about moving the pm_eta_conv adaptions and vm_deltaCap fixings out of initialCap, too?

  Execute_Loadpoint 'input_ref' pm_eta_conv = pm_eta_conv;
  Execute_Loadpoint 'input_ref' o_INI_DirProdSeTe = o_INI_DirProdSeTe;
  Execute_Loadpoint 'input_ref' pm_EN_demand_from_initialcap2 = pm_EN_demand_from_initialcap2;
  Execute_Loadpoint 'input_ref' pm_pedem_res = pm_pedem_res;
  Execute_Loadpoint 'input_ref' pm_dataeta = pm_dataeta;
  Execute_Loadpoint 'input_ref' pm_aux_capLowerLimit = pm_aux_capLowerLimit;
  Execute_Loadpoint 'input_ref' vm_deltaCap.l = vm_deltaCap.l;
  Execute_Loadpoint 'input_ref' vm_deltaCap.lo = vm_deltaCap.lo;
  Execute_Loadpoint 'input_ref' vm_deltaCap.up = vm_deltaCap.up;

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
    Still doing some to make sure it actually changes the parameters.
  • Comparison of results (what changes by this PR?):

Felix Schreyer added 2 commits September 17, 2024 15:05
@Renato-Rodrigues Renato-Rodrigues requested review from JakobBD and removed request for JakobBD September 19, 2024 12:56
@fschreyer
Copy link
Contributor Author

Also including @tabeado and @amerfort as the switch affects CO2 capture rates.

@fschreyer fschreyer merged commit 982b8fc into remindmodel:develop Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants